Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

2014-12-19 Thread Gonglei
On 2014/12/20 1:27, Markus Armbruster wrote: > I don't understand why you move declarations to sysemu.h, and I had a > few remarks here and there. But I couldn't see anything wrong, so: > My thought is just moving the code related boot order to a unified place. :( > Series > Reviewed-by: Marku

Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > Changes of v2: > Thanks to Peter's report and suggestion. > - fix 'make check' complaint. > - fix inapposite using &error_abort in patch 5. > > Because of Peter's review comments in a pull request, I start a new > round review about this patch series v2. Please rev

[Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

2014-12-17 Thread arei.gonglei
From: Gonglei Changes of v2: Thanks to Peter's report and suggestion. - fix 'make check' complaint. - fix inapposite using &error_abort in patch 5. Because of Peter's review comments in a pull request, I start a new round review about this patch series v2. Please review, Thanks. Patch 1 just