Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
On 2014/11/3 23:33, Markus Armbruster wrote: zhanghailiang writes: On 2014/11/3 18:03, Michael Tokarev wrote: 03.11.2014 12:44, zhanghailiang wrote: Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use error_setg wh

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
On 2014/11/3 22:10, Michael Tokarev wrote: 03.11.2014 14:39, zhanghailiang wrote: On 2014/11/3 18:03, Michael Tokarev wrote: 03.11.2014 12:44, zhanghailiang wrote: Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread Markus Armbruster
zhanghailiang writes: > On 2014/11/3 18:03, Michael Tokarev wrote: >> 03.11.2014 12:44, zhanghailiang wrote: >>> Patch 1~3 fix wrong check about in-parameter. >>> The last two patches convert some open functions to use Error API. >>> >>> v2: >>> - don't use error_setg when followed by exit(), it

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread Michael Tokarev
03.11.2014 14:39, zhanghailiang wrote: > On 2014/11/3 18:03, Michael Tokarev wrote: >> 03.11.2014 12:44, zhanghailiang wrote: >>> Patch 1~3 fix wrong check about in-parameter. >>> The last two patches convert some open functions to use Error API. >>> >>> v2: >>> - don't use error_setg when followed

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
On 2014/11/3 18:03, Michael Tokarev wrote: 03.11.2014 12:44, zhanghailiang wrote: Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use error_setg when followed by exit(), it does not report an error (Eric Blake) - chec

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread Michael Tokarev
03.11.2014 12:44, zhanghailiang wrote: > Patch 1~3 fix wrong check about in-parameter. > The last two patches convert some open functions to use Error API. > > v2: > - don't use error_setg when followed by exit(), it does not report an error > (Eric Blake) > - check the parameter in qemu_chr_pars

[Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use error_setg when followed by exit(), it does not report an error (Eric Blake) - check the parameter in qemu_chr_parse_* functions and remove the check in qemu_chr_open_