Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-07 Thread Stefan Weil
Am 06.03.2012 08:41, schrieb Jan Kiszka: On 2012-03-05 10:06, Jan Kiszka wrote: Grmbl. Was very hard to reproduce here (triggered once every few hours with lots of interaction beforehand), but now I think I got the point (recursion of if_start due to if_encap). Will rework the code to address th

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-05 Thread Jan Kiszka
On 2012-03-05 10:06, Jan Kiszka wrote: > Grmbl. Was very hard to reproduce here (triggered once every few hours > with lots of interaction beforehand), but now I think I got the point > (recursion of if_start due to if_encap). Will rework the code to address > this. > > Thanks for testing so far,

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-05 Thread Jan Kiszka
On 2012-03-02 22:05, Stefan Weil wrote: > Am 02.03.2012 19:57, schrieb Jan Kiszka: >> Well, this requeuing bug seems to have a long breath. Previous attempts >> to fix it (mine included) neglected the fact that we need to walk the >> queue of pending packets, not just restart from the beginning aft

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-02 Thread Stefan Weil
Am 02.03.2012 19:57, schrieb Jan Kiszka: Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a requeue. This version should get it Right(TM

[Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-02 Thread Jan Kiszka
Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a requeue. This version should get it Right(TM). This also comes with a fix for resource