Re: [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext

2017-09-21 Thread Marc-André Lureau
On Thu, Sep 21, 2017 at 8:35 AM, Peter Xu wrote: > The old chardev may not fully support non-default GMainContext. One > direct clue is that when we call io_add_watch_poll() sometimes we are > still passing in the NULL context pointer. > > IIUC we are fine during setup since the context will be p

[Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext

2017-09-20 Thread Peter Xu
The old chardev may not fully support non-default GMainContext. One direct clue is that when we call io_add_watch_poll() sometimes we are still passing in the NULL context pointer. IIUC we are fine during setup since the context will be passed correctly during setup via chr_update_read_handler().