Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute

2010-01-21 Thread Christoph Hellwig
On Thu, Jan 21, 2010 at 03:19:28PM +0200, Naphtali Sprei wrote: > > > > > - we now normally set the read_only flag from bdrv_open2 when we do > >not have the O_RDWR flag set > > - but the block drivers also mess with it: > > o raw-posix superflously sets it when BDRV_O_RDWR is not in th

Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute

2010-01-21 Thread Naphtali Sprei
Christoph Hellwig wrote: > Looking at the version of this that landed in git I don't think the > read-only handling is entirely clean after this. I fixed what I could, still I got some questions below. > > - we now normally set the read_only flag from bdrv_open2 when we do >not have the O_R

Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute

2010-01-20 Thread Christoph Hellwig
Looking at the version of this that landed in git I don't think the read-only handling is entirely clean after this. - we now normally set the read_only flag from bdrv_open2 when we do not have the O_RDWR flag set - but the block drivers also mess with it: o raw-posix superflously set

[Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute

2010-01-17 Thread Naphtali Sprei
This is version 2, to replace previous set. Addresses all Kevin comments. Naphtali Sprei (4): Make CDROM a read-only drive Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need