Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

2016-03-08 Thread Kevin Wolf
Am 08.03.2016 um 09:24 hat Fam Zheng geschrieben: > All three functions are not in hot path (all run once for the BDS lifecycle), > so it's okay to convert to g_malloc0. Yeah, it's okay, but still kind of useless to memset the whole buffer before you overwrite it anyway. There's also a useless ret

Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 09:24, Fam Zheng wrote: > All three functions are not in hot path (all run once for the BDS lifecycle), > so it's okay to convert to g_malloc0. > > Fam > > > Fam Zheng (3): > vmdk: Switch to heap arrays for vmdk_write_cid > vmdk: Switch to heap arrays for vmdk_read_cid > vm

[Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

2016-03-08 Thread Fam Zheng
All three functions are not in hot path (all run once for the BDS lifecycle), so it's okay to convert to g_malloc0. Fam Fam Zheng (3): vmdk: Switch to heap arrays for vmdk_write_cid vmdk: Switch to heap arrays for vmdk_read_cid vmdk: Switch to heap arrays for vmdk_parent_open block/vmdk.