Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Kevin Wolf
Am 07.02.2014 um 15:47 hat Olaf Hering geschrieben: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering > --- > v2:

Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Olaf Hering
On Fri, Feb 07, Stefano Stabellini wrote: > added to my queue, I'll fix the tab manually Thanks, sorry for the TAB. Olaf

Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Stefano Stabellini
On Fri, 7 Feb 2014, Olaf Hering wrote: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering added to my queue, I'll

[Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Olaf Hering
bdrv_acct_done was called unconditional. But in case the ioreq has no segments there is no matching bdrv_acct_start call. This could lead to bogus accounting values. Found by code inspection. Signed-off-by: Olaf Hering --- v2: add comment /* fall through */ hw/block/xen_disk.c | 14 +