Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-20 Thread Greg Kurz
On Tue, 20 Mar 2018 11:27:26 +0800 Jason Wang wrote: > >>   -static > >>   void qemu_flush_or_purge_queued_packets(NetClientState *nc, bool > >> purge) > >>   { > >>   nc->receive_disabled = 0; > >> > >> > > > > Applied and queued for -stable. > > > > Thanks > > > > Unfortunately, this

Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-19 Thread Jason Wang
  -static   void qemu_flush_or_purge_queued_packets(NetClientState *nc, bool purge)   {   nc->receive_disabled = 0; Applied and queued for -stable. Thanks Unfortunately, this breaks hotplug test:  TEST: tests/virtio-net-test... (pid=7117) /x86_64/virtio/net/pci/basic: OK /x86_64/v

Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-19 Thread Jason Wang
On 2018年03月16日 20:07, Greg Kurz wrote: If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is compl

[Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Greg Kurz
If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is complete. If a reset happens before completion,