Re: [Qemu-devel] [PATCH v2] virtio-scsi: Allocate op blocker reason before blocking

2015-02-27 Thread Paolo Bonzini
On 27/02/2015 18:11, Max Reitz wrote: > s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places > where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is > allocated and when it is freed. That does not make a whole lot of sense > (and is actually wrong because this lead

Re: [Qemu-devel] [PATCH v2] virtio-scsi: Allocate op blocker reason before blocking

2015-02-27 Thread Eric Blake
On 02/27/2015 10:11 AM, Max Reitz wrote: > s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places > where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is > allocated and when it is freed. That does not make a whole lot of sense > (and is actually wrong because this lea

[Qemu-devel] [PATCH v2] virtio-scsi: Allocate op blocker reason before blocking

2015-02-27 Thread Max Reitz
s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually wrong because this leads to s->blocker potentially being NULL when blk_