Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-17 Thread Stefan Hajnoczi
On Tue, Nov 17, 2015 at 03:28:29PM +0800, Fam Zheng wrote: > On Tue, 11/17 14:58, Stefan Hajnoczi wrote: > > On Mon, Nov 16, 2015 at 02:10:36PM +0800, Fam Zheng wrote: > > > When a request R is absorbed by request M, it is appended to the > > > "mr_next" queue led by M, and is completed together wi

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Fam Zheng
On Tue, 11/17 14:58, Stefan Hajnoczi wrote: > On Mon, Nov 16, 2015 at 02:10:36PM +0800, Fam Zheng wrote: > > When a request R is absorbed by request M, it is appended to the > > "mr_next" queue led by M, and is completed together with the completion > > of M, in virtio_blk_rw_complete. > > > > Wit

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 02:10:36PM +0800, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Laurent Vivier
On 16/11/2015 07:10, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R also gets > prepen

[Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Fam Zheng
When a request R is absorbed by request M, it is appended to the "mr_next" queue led by M, and is completed together with the completion of M, in virtio_blk_rw_complete. With error policy equals stop, if M has an I/O error, now R also gets prepended to the per device DMA restart queue, which will