Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Nikolay Nikolaev
On Thu, Jun 26, 2014 at 1:22 PM, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- > docs/specs/vhost-user.txt | 7 --- > exec.c| 7

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 11:51:51AM +, Damjan Marion (damarion) wrote: > > On 26 Jun 2014, at 13:37, Michael S. Tsirkin wrote: > > > On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: > >> > >> On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > >> > >>> On Thu, Ju

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- > docs/specs/vhost-user.txt | 7 --- > exec.c

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 13:37, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: >> >>> On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: Old code was affected by memory

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: > > On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > > > On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: > >> Old code was affected by memory gaps which > >> resulted in buffer pointers pointing to > >>

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- > >

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- changelog? does not look like all comments have been addressed.

[Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion
Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Signed-off-by: Damjan Marion --- docs/specs/vhost-user.txt | 7 --- exec.c| 7 +++ hw/virtio/vhost-user.c| 23 ++- inclu