Re: [Qemu-devel] [PATCH v2] util/id: fully allocate names table

2015-11-29 Thread Michael Tokarev
26.11.2015 00:03, John Snow wrote: > Trivial: this array should be allocated to have ID_MAX entries always. > Otherwise if someone were to forget to expand this table, the assertion > in the id generator won't actually trigger; it will read junk data. Applied to -trivial as a bugfix, with a trivia

Re: [Qemu-devel] [PATCH v2] util/id: fully allocate names table

2015-11-25 Thread Jeff Cody
On Wed, Nov 25, 2015 at 04:03:37PM -0500, John Snow wrote: > Trivial: this array should be allocated to have ID_MAX entries always. > Otherwise if someone were to forget to expand this table, the assertion > in the id generator won't actually trigger; it will read junk data. > > v2: Fix the range

Re: [Qemu-devel] [PATCH v2] util/id: fully allocate names table

2015-11-25 Thread Eric Blake
On 11/25/2015 02:03 PM, John Snow wrote: > Trivial: this array should be allocated to have ID_MAX entries always. > Otherwise if someone were to forget to expand this table, the assertion > in the id generator won't actually trigger; it will read junk data. > > v2: Fix the range assertion, too. Co

[Qemu-devel] [PATCH v2] util/id: fully allocate names table

2015-11-25 Thread John Snow
Trivial: this array should be allocated to have ID_MAX entries always. Otherwise if someone were to forget to expand this table, the assertion in the id generator won't actually trigger; it will read junk data. v2: Fix the range assertion, too. Compare against the known actual size of the tabl