Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-16 Thread John Snow
On 9/16/19 4:00 AM, Kevin Wolf wrote: > Am 13.09.2019 um 20:49 hat John Snow geschrieben: >> On 9/12/19 4:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Also, I'm not sure about "are" suggested by Max. "are" is for plural, but >>> here I meant >>> one object: sum of @start and @count. >>> >> >>

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-16 Thread Kevin Wolf
Am 13.09.2019 um 20:49 hat John Snow geschrieben: > On 9/12/19 4:20 AM, Vladimir Sementsov-Ogievskiy wrote: > > Also, I'm not sure about "are" suggested by Max. "are" is for plural, but > > here I meant > > one object: sum of @start and @count. > > > > There's not great agreement universally abo

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-13 Thread John Snow
On 9/12/19 4:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.09.2019 20:59, John Snow wrote: >> >> >> On 9/11/19 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 07.08.2019 19:27, John Snow wrote: On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: > 06.08.2019 19:09, Max

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-12 Thread Vladimir Sementsov-Ogievskiy
11.09.2019 20:59, John Snow wrote: > > > On 9/11/19 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.08.2019 19:27, John Snow wrote: >>> >>> >>> On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: 06.08.2019 19:09, Max Reitz wrote: > On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-11 Thread John Snow
On 9/11/19 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2019 19:27, John Snow wrote: >> >> >> On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.08.2019 19:09, Max Reitz wrote: On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: > hbitmap_reset has an unobvious p

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-11 Thread Vladimir Sementsov-Ogievskiy
07.08.2019 19:27, John Snow wrote: > > > On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: >> 06.08.2019 19:09, Max Reitz wrote: >>> On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: hbitmap_reset has an unobvious property: it rounds requested region up. It may provoke bugs,

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-08-07 Thread John Snow
On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: > 06.08.2019 19:09, Max Reitz wrote: >> On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: >>> hbitmap_reset has an unobvious property: it rounds requested region up. >>> It may provoke bugs, like in recently fixed write-blocking mode o

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-08-06 Thread Vladimir Sementsov-Ogievskiy
06.08.2019 19:09, Max Reitz wrote: > On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: >> hbitmap_reset has an unobvious property: it rounds requested region up. >> It may provoke bugs, like in recently fixed write-blocking mode of >> mirror: user calls reset on unaligned region, not keeping i

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-08-06 Thread Max Reitz
On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: > hbitmap_reset has an unobvious property: it rounds requested region up. > It may provoke bugs, like in recently fixed write-blocking mode of > mirror: user calls reset on unaligned region, not keeping in mind that > there are possible unrelat

[Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-08-06 Thread Vladimir Sementsov-Ogievskiy
hbitmap_reset has an unobvious property: it rounds requested region up. It may provoke bugs, like in recently fixed write-blocking mode of mirror: user calls reset on unaligned region, not keeping in mind that there are possible unrelated dirty bytes, covered by rounded-up region and information of