Re: [Qemu-devel] [PATCH v2] ui/vnc.c: polish vnc_init_func

2018-10-15 Thread Fei Li
On 10/15/2018 03:58 PM, Markus Armbruster wrote: Fei Li writes: Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let its callees propagate the Error, like init_keyboard_layout(). Signed-off-by: Fei Li

Re: [Qemu-devel] [PATCH v2] ui/vnc.c: polish vnc_init_func

2018-10-15 Thread Markus Armbruster
Fei Li writes: > Add a new Error parameter for vnc_display_init() to handle errors > in its caller: vnc_init_func(), just like vnc_display_open() does. > And let its callees propagate the Error, like init_keyboard_layout(). > > Signed-off-by: Fei Li > --- > include/ui/console.h | 2 +- > ui/cu

Re: [Qemu-devel] [PATCH v2] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Philippe Mathieu-Daudé
Hi Fei, On 12/10/2018 13:50, Fei Li wrote: > Add a new Error parameter for vnc_display_init() to handle errors > in its caller: vnc_init_func(), just like vnc_display_open() does. > And let its callees propagate the Error, like init_keyboard_layout(). > > Signed-off-by: Fei Li > --- > include/u

Re: [Qemu-devel] [PATCH v2] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Fei Li
On 10/12/2018 07:50 PM, Fei Li wrote: Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let its callees propagate the Error, like init_keyboard_layout(). Signed-off-by: Fei Li As this version do a big adj

[Qemu-devel] [PATCH v2] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Fei Li
Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let its callees propagate the Error, like init_keyboard_layout(). Signed-off-by: Fei Li --- include/ui/console.h | 2 +- ui/curses.c | 4 +++- ui/ke