Re: [Qemu-devel] [PATCH v2] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-11 Thread Richard Henderson
On 11/11/2016 12:21 PM, Laurent Vivier wrote: Le 11/11/2016 à 08:31, Richard Henderson a écrit : On 11/10/2016 11:51 PM, Laurent Vivier wrote: +/* Result of rotate_x() is valid if 0 < shift < (size + 1) < 32 */ +static TCGv rotate_x(TCGv dest, TCGv src, TCGv shift, int left, int size) +{ +T

Re: [Qemu-devel] [PATCH v2] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-11 Thread Laurent Vivier
Le 11/11/2016 à 08:31, Richard Henderson a écrit : > On 11/10/2016 11:51 PM, Laurent Vivier wrote: >> +/* Result of rotate_x() is valid if 0 < shift < (size + 1) < 32 */ >> +static TCGv rotate_x(TCGv dest, TCGv src, TCGv shift, int left, int >> size) >> +{ >> +TCGv X, shl, shr, shx; >> + >> +

Re: [Qemu-devel] [PATCH v2] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-10 Thread Richard Henderson
On 11/10/2016 11:51 PM, Laurent Vivier wrote: +/* Result of rotate_x() is valid if 0 < shift < (size + 1) < 32 */ +static TCGv rotate_x(TCGv dest, TCGv src, TCGv shift, int left, int size) +{ +TCGv X, shl, shr, shx; + +shr = tcg_temp_new(); +shl = tcg_temp_new(); +shx = tcg_temp_n

[Qemu-devel] [PATCH v2] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-10 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- v2: - use shift to do rotate_x() for 8 and 16bit value - rotate_x()/rotate32_x() are a no-op when shift % (size + 1) == 0 - add some missing tcg_temp_free() target-m68k/translate.c | 414 1 file changed, 414 inse