Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-11-19 Thread Michael S. Tsirkin
On Thu, Nov 20, 2014 at 07:05:17AM +0100, Paolo Bonzini wrote: > > > On 11/11/2014 18:13, Paolo Bonzini wrote: > > On 15/10/2014 09:45, Paolo Bonzini wrote: > >> This makes it simpler to keep the SSDT byte-for-byte identical for a > >> given machine type, which is a goal we want to have for 2.2 a

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-11-19 Thread Paolo Bonzini
On 11/11/2014 18:13, Paolo Bonzini wrote: > On 15/10/2014 09:45, Paolo Bonzini wrote: >> This makes it simpler to keep the SSDT byte-for-byte identical for a >> given machine type, which is a goal we want to have for 2.2 and newer >> types. >> >> Signed-off-by: Paolo Bonzini >> --- >> v1

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-11-11 Thread Paolo Bonzini
On 15/10/2014 09:45, Paolo Bonzini wrote: > This makes it simpler to keep the SSDT byte-for-byte identical for a > given machine type, which is a goal we want to have for 2.2 and newer > types. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: do not define the same Device twice (Igor) >

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-10-16 Thread Paolo Bonzini
Il 15/10/2014 15:19, Igor Mammedov ha scritto: > however I'm not sure that SSDT byte-for-byte compatible will make > things better. > Since SSDT includes snippets of AML compiled by IASL, hex-templates > could be different depending on IASL version. SSDT is simple enough that there shouldn't be di

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-10-15 Thread Michael S. Tsirkin
On Wed, Oct 15, 2014 at 03:19:00PM +0200, Igor Mammedov wrote: > On Wed, 15 Oct 2014 09:45:44 +0200 > Paolo Bonzini wrote: > > > This makes it simpler to keep the SSDT byte-for-byte identical for a > > given machine type, which is a goal we want to have for 2.2 and newer > > types. > > > > Signe

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-10-15 Thread Igor Mammedov
On Wed, 15 Oct 2014 09:45:44 +0200 Paolo Bonzini wrote: > This makes it simpler to keep the SSDT byte-for-byte identical for a > given machine type, which is a goal we want to have for 2.2 and newer > types. > > Signed-off-by: Paolo Bonzini Moving static code to DSDT is resonable, hence Review

[Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-10-15 Thread Paolo Bonzini
This makes it simpler to keep the SSDT byte-for-byte identical for a given machine type, which is a goal we want to have for 2.2 and newer types. Signed-off-by: Paolo Bonzini --- v1->v2: do not define the same Device twice (Igor) hw/i386/acpi-dsdt-mem-hotplug.dsl | 176 hw/i3