Re: [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache dump

2013-08-24 Thread Peter Maydell
On 23 August 2013 20:09, Tobias Markus wrote: > When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default > operation size bit (D/B bit) is not set for Long Mode Data Segments since > there are only Data Segments in Long Mode and no explicit 16/32/64-bit > Descriptors. > This patch

Re: [Qemu-devel] [PATCH v2] target-i386: Fix segment cache dump

2013-08-23 Thread Eric Blake
On 08/23/2013 03:39 PM, Tobias Markus wrote: > Alternatively, for readability: > +cpu_fprintf(f, (sc->flags & DESC_B_MASK || env->hflags & > HF_LMA_MASK) > +? "DS " : "DS16"); > The upper line would be 82 characters long. I'm not sure how strictly line > w

Re: [Qemu-devel] [PATCH v2] target-i386: Fix segment cache dump

2013-08-23 Thread Tobias Markus
On 08/23/2013 10:01 PM, Richard Henderson wrote: > On 08/23/2013 12:09 PM, Tobias Markus wrote: >> When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default >> operation size bit (D/B bit) is not set for Long Mode Data Segments since >> there are only Data Segments in Long Mode and n

Re: [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache dump

2013-08-23 Thread Richard Henderson
On 08/23/2013 12:09 PM, Tobias Markus wrote: > When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default > operation size bit (D/B bit) is not set for Long Mode Data Segments since > there are only Data Segments in Long Mode and no explicit 16/32/64-bit > Descriptors. > This patch f

[Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache dump

2013-08-23 Thread Tobias Markus
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default operation size bit (D/B bit) is not set for Long Mode Data Segments since there are only Data Segments in Long Mode and no explicit 16/32/64-bit Descriptors. This patch fixes this by checking the Long Mode Active bit of the hi