Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
Hi, Okay, thanks for the suggestion, I'll try that and resend the v2 patch, let's see what happens. Perfect. unless quoted-printable (and base64 while at it) support is added to "git am", this is going to be a common problem for mails sent to qemu-devel. My git version handles it just fi

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Riku Voipio
On Thu, Oct 22, 2009 at 02:03:30PM +0200, juha.riihim...@nokia.com wrote: > On Oct 22, 2009, at 13:08, ext Gerd Hoffmann wrote: > > Something "git am" can handle would be best. "git send-email" would > > be > > perfect if you can get that work. 'git send-email --smtp-server > > $internalmailse

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 13:08, ext Gerd Hoffmann wrote: > On 10/22/09 11:55, juha.riihim...@nokia.com wrote: > > Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. >>> >>> Makes it very difficult to extract the patches in a automated >>> way ... >> >> Well, I tes

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
On 10/22/09 11:55, juha.riihim...@nokia.com wrote: Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ... Well, I tested that the formatting stays correct if I send the mail body HTML format instead of

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 12:10, ext Gerd Hoffmann wrote: > On 10/22/09 10:35, juha.riihim...@nokia.com wrote: >>> Hi, >>> -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) >>> >>> Your mailer mangles the patches. >> >> Yes, I know, I can't help it, I'm sorry.

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
On 10/22/09 10:35, juha.riihim...@nokia.com wrote: Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ... That

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 11:04, ext Gerd Hoffmann wrote: > > Hi, > >> -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, >> tcg_const_i32(mask)) > > Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. That's why I include the patch as an attachment as well -- the at

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. cheers, Gerd

[Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-21 Thread Juha.Riihimaki
Revised patch for getting rid of tcg temporary variable leaks in target-arm/translate.c. This version also includes the leak patch for gen_set_cpsr macro, now converted as a static inline function, which I sent earlier as a separate patch on top of this patch. This patch (the attached version) shou