Re: [Qemu-devel] [PATCH v2] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-05 Thread Martin Galvan
Once again, you're right. I'll fix that right away and send v3. On Fri, Sep 5, 2014 at 2:43 PM, Peter Maydell wrote: > On 4 September 2014 19:12, Martin Galvan > wrote: > > Thanks for this patch. I think it's generally right > but could use a little tweaking for style issues. > >> When calling q

Re: [Qemu-devel] [PATCH v2] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-05 Thread Peter Maydell
On 4 September 2014 19:12, Martin Galvan wrote: Thanks for this patch. I think it's generally right but could use a little tweaking for style issues. > When calling qemu_system_reset after startup on a Cortex-M CPU, the > initial values of PC, MSP and the Thumb bit weren't set correctly Add "if

[Qemu-devel] [PATCH v2] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-04 Thread Martin Galvan
When calling qemu_system_reset after startup on a Cortex-M CPU, the initial values of PC, MSP and the Thumb bit weren't set correctly. In particular, since Thumb was 0, a Usage Fault would arise immediately after trying to excecute any instruction on a Cortex-M. Signed-off-by: Martin Galvan ---