Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Benjamin Herrenschmidt
> > I find your lack of taste disturbing Luke :-) > > Heh :). I merely try to not collide with laws I can't influence easily and > don't bother to change enough ;). Compliance with established authority has never been my strong point :-) > >> Yeah, it's a shame I didn't read through it more t

Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Alexander Graf
On 25.05.2012, at 11:24, Benjamin Herrenschmidt wrote: > On Fri, 2012-05-25 at 10:54 +0200, Alexander Graf wrote: > case x: foo(); break(); > break; > +case 1: tmp = lduw_phys(src); break; > +case 2: tmp = ldl_phys(src); break; > +

Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Benjamin Herrenschmidt
On Fri, 2012-05-25 at 10:54 +0200, Alexander Graf wrote: > >> case x: > >>foo(); > >>break(); > >> > >>> break; > >>> +case 1: tmp = lduw_phys(src); break; > >>> +case 2: tmp = ldl_phys(src); break; > >>> +case 3: tmp = ldq_phys(src); break; > >>> +defaul

Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Alexander Graf
On 25.05.2012, at 10:36, Benjamin Herrenschmidt wrote: > On Fri, 2012-05-25 at 10:30 +0200, Alexander Graf wrote: > >>> +while (count--) { >>> +switch (esize) { >>> +case 0: tmp = ldub_phys(src); >> >> I'm surprised checkpatch didn't complain here. Please do >> >> case x

Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Benjamin Herrenschmidt
On Fri, 2012-05-25 at 10:30 +0200, Alexander Graf wrote: > > +while (count--) { > > +switch (esize) { > > +case 0: tmp = ldub_phys(src); > > I'm surprised checkpatch didn't complain here. Please do > > case x: > foo(); > break(); > > > break; > > +case 1: tmp

Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-25 Thread Alexander Graf
On 25.05.2012, at 05:53, Benjamin Herrenschmidt wrote: > This adds a qemu-specific hypervisor call to the pseries machine > which allows to do what amounts to memmove, memcpy and xor over > regions of physical memory such as the framebuffer. > > This is the simplest way to get usable framebuf

[Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-24 Thread Benjamin Herrenschmidt
This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer speed from SLOF since the framebuffer isn't mapped in the VRMA and