Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-26 Thread Markus Armbruster
Paolo Bonzini writes: > Il 20/03/2014 08:32, Markus Armbruster ha scritto: > +static void __write(uint8_t *buf, int len) Will the fact that you used 'int len' instead of 'size_t' bite us on 32- vs. 64-bit? Same for __read. >>> >>> Yeah, I copied this from address_space_rw. I'

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 08:32, Markus Armbruster ha scritto: +static void __write(uint8_t *buf, int len) Will the fact that you used 'int len' instead of 'size_t' bite us on 32- vs. 64-bit? Same for __read. Yeah, I copied this from address_space_rw. I'll change to ssize_t to catch negative values.

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Markus Armbruster
Paolo Bonzini writes: > Il 19/03/2014 18:32, Eric Blake ha scritto: >>> + * >>> + * Copyright (C) 2014 Red Hat, Inc. >>> + * >>> + * Authors: >>> + * Markus Armbruster >>> + * Paolo Bonzini >>> + * >>> + * This work is licensed under the terms of the GNU GPL, version 2 >>> or, at your >>> + *

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Markus Armbruster
Paolo Bonzini writes: > This is the model file that is being used for the QEMU project's scans > on scan.coverity.com. It fixed about 30 false positives (10% of the > total) and exposed about 60 new memory leaks. > > The file is not automatically used; changes to it must be propagated > to the w

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-19 Thread Paolo Bonzini
Il 19/03/2014 18:32, Eric Blake ha scritto: + * + * Copyright (C) 2014 Red Hat, Inc. + * + * Authors: + * Markus Armbruster + * Paolo Bonzini + * + * This work is licensed under the terms of the GNU GPL, version 2 or, at your + * option, any later version. See the COPYING file in the top-lev

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-19 Thread Eric Blake
On 03/19/2014 10:52 AM, Paolo Bonzini wrote: > This is the model file that is being used for the QEMU project's scans > on scan.coverity.com. It fixed about 30 false positives (10% of the > total) and exposed about 60 new memory leaks. > > The file is not automatically used; changes to it must be

[Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-19 Thread Paolo Bonzini
This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not automatically used; changes to it must be propagated to the website manually by an admin (right