Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-14 Thread Eric Blake
On 09/14/2016 04:02 PM, Thomas Huth wrote: > Well, /bin/bash is also not really portable ... I've seen systems in the > past where bash was installed in another directory or not at all... True, but we already liberally use /bin/bash scripts elsewhere in qemu.git, so at least you wouldn't be the fi

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-14 Thread Thomas Huth
On 14.09.2016 16:44, Eric Blake wrote: > On 09/14/2016 05:35 AM, Thomas Huth wrote: >> Erik, > > It's Eric, but don't sweat it (you're not the first, and probably not > the last, to typo names) Oops, big sorry! I must have been confused by the German spelling of that name :-( > +while [ $# -

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-14 Thread Eric Blake
On 09/14/2016 05:35 AM, Thomas Huth wrote: > Erik, It's Eric, but don't sweat it (you're not the first, and probably not the last, to typo names) +while [ $# -ge 1 ]; do + case "$1" in +-s) START="$2" ; shift ;; >>> >>> POSIX recommends that short options with arguments be

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-14 Thread Thomas Huth
Erik, thanks a lot for your detailed review and comments ... I somewhat suspected that my shell-script-fu is crap, but now I also have the confirmation ;-) Anyway, some comments below... On 13.09.2016 18:06, Daniel P. Berrange wrote: > On Tue, Sep 13, 2016 at 10:48:46AM -0500, Eric Blake wrote: >

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 10:48:46AM -0500, Eric Blake wrote: > On 09/13/2016 08:20 AM, Thomas Huth wrote: > > Basic idea of this script is to check the git log for URLs > > to the QEMU bugtracker at launchpad.net and to figure out > > whether the related bug has been marked there as "Fix released" >

Re: [Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-13 Thread Eric Blake
On 09/13/2016 08:20 AM, Thomas Huth wrote: > Basic idea of this script is to check the git log for URLs > to the QEMU bugtracker at launchpad.net and to figure out > whether the related bug has been marked there as "Fix released" > (i.e. closed) already. So this script can e.g. be used after > each

[Qemu-devel] [PATCH v2] scripts: Add a script to check for bug URLs in the git log

2016-09-13 Thread Thomas Huth
Basic idea of this script is to check the git log for URLs to the QEMU bugtracker at launchpad.net and to figure out whether the related bug has been marked there as "Fix released" (i.e. closed) already. So this script can e.g. be used after each public release of QEMU to check whether there are an