Re: [Qemu-devel] [PATCH v2] qxl-render: add more sanity checks

2014-08-29 Thread Gerd Hoffmann
On Fr, 2014-08-29 at 06:09 -0600, Eric Blake wrote: > s/enouth/enough/ fixed, thanks, Gerd signature.asc Description: This is a digitally signed message part

Re: [Qemu-devel] [PATCH v2] qxl-render: add more sanity checks

2014-08-29 Thread Eric Blake
On 08/29/2014 01:56 AM, Gerd Hoffmann wrote: > Damn, the dirty rectangle values are signed integers. So the checks > added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good > enouth, we also have to make sure they are not negative. s/enouth/enough/ > > [ Note: There must be someth

Re: [Qemu-devel] [PATCH v2] qxl-render: add more sanity checks

2014-08-29 Thread Gerd Hoffmann
Hi, > Reviewed-by: Dr. David Alan Gilbert > > Should this go for stable as well? Yep. Added cc qemu-stable. > (I was worried for a sec about what happens if right=width or bottom=height; > but looking at the code below it I think it's a dirty from left..(right-1) > so we're OK?) Correct.

Re: [Qemu-devel] [PATCH v2] qxl-render: add more sanity checks

2014-08-29 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Damn, the dirty rectangle values are signed integers. So the checks > added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good > enouth, we also have to make sure they are not negative. > > [ Note: There must be something broken in spice-s

[Qemu-devel] [PATCH v2] qxl-render: add more sanity checks

2014-08-29 Thread Gerd Hoffmann
Damn, the dirty rectangle values are signed integers. So the checks added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good enouth, we also have to make sure they are not negative. [ Note: There must be something broken in spice-server so we get negative values in the first place.