Re: [Qemu-devel] [PATCH v2] qga: Support enum names in guest-file-seek

2016-01-19 Thread Eric Blake
ping On 12/18/2015 10:44 AM, Eric Blake wrote: > Magic constants are a pain to use, especially when we run the > risk that our choice of '1' for QGA_SEEK_CUR might differ from > the host or guest's choice of SEEK_CUR. Better is to use an > enum value, via a qapi alternate type for back-compatibil

[Qemu-devel] [PATCH v2] qga: Support enum names in guest-file-seek

2015-12-18 Thread Eric Blake
Magic constants are a pain to use, especially when we run the risk that our choice of '1' for QGA_SEEK_CUR might differ from the host or guest's choice of SEEK_CUR. Better is to use an enum value, via a qapi alternate type for back-compatibility. With this, {"command":"guest-file-seek", "argumen