Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-10-01 Thread Michael Roth
Quoting zhanghailiang (2014-09-18 22:09:10) > If readdir_r fails, error_setg_errno will reference the freed > pointer *dirpath*. > > Moreover, readdir_r may cause a buffer overflow, using readdir instead. > > Signed-off-by: zhanghailiang Thanks, applied to qga tree: https://github.com/mdroth/q

Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-27 Thread zhanghailiang
On 2014/9/26 23:40, Paolo Bonzini wrote: Il 19/09/2014 05:09, zhanghailiang ha scritto: If readdir_r fails, error_setg_errno will reference the freed pointer *dirpath*. Moreover, readdir_r may cause a buffer overflow, using readdir instead. Signed-off-by: zhanghailiang --- v2: - Switch read

Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-26 Thread Eric Blake
On 09/18/2014 09:09 PM, zhanghailiang wrote: > If readdir_r fails, error_setg_errno will reference the freed > pointer *dirpath*. > > Moreover, readdir_r may cause a buffer overflow, using readdir instead. > > Signed-off-by: zhanghailiang > --- > v2: > - Switch readdir_r to readdir (Comment of

Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-26 Thread Paolo Bonzini
Il 19/09/2014 05:09, zhanghailiang ha scritto: > If readdir_r fails, error_setg_errno will reference the freed > pointer *dirpath*. > > Moreover, readdir_r may cause a buffer overflow, using readdir instead. > > Signed-off-by: zhanghailiang > --- > v2: > - Switch readdir_r to readdir (Comment o

Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-26 Thread zhanghailiang
Hi, Ping...,plus;) This is a bug fix. Thanks, zhanghailiang On 2014/9/19 11:09, zhanghailiang wrote: If readdir_r fails, error_setg_errno will reference the freed pointer *dirpath*. Moreover, readdir_r may cause a buffer overflow, using readdir instead. Signed-off-by: zhanghailiang --- v2

[Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-18 Thread zhanghailiang
If readdir_r fails, error_setg_errno will reference the freed pointer *dirpath*. Moreover, readdir_r may cause a buffer overflow, using readdir instead. Signed-off-by: zhanghailiang --- v2: - Switch readdir_r to readdir (Comment of Eric Blake) --- qga/commands-posix.c | 27 +++-