Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-15 Thread Kevin Wolf
Am 15.05.2014 um 15:07 hat Mike Day geschrieben: > On Wed, May 14, 2014 at 11:15 AM, Kevin Wolf wrote: > >> freeing the extra clusters. > > > > Do you have an easy reproducer? Because I can't see the bug. > > Thanks for the review! I was having a hard time reproducing this until > I did a bisect.

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-15 Thread Mike Day
On Wed, May 14, 2014 at 11:15 AM, Kevin Wolf wrote: >> freeing the extra clusters. > > Do you have an easy reproducer? Because I can't see the bug. Thanks for the review! I was having a hard time reproducing this until I did a bisect. This bug was fixed by 65f33bc which was merged at or after th

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-14 Thread Max Reitz
On 12.05.2014 22:27, Mike Day wrote: When deleting the last snapshot, copying the resulting snapshot table currently fails, causing the delete operation to also fail. Fix the failure by skipping the copy and just writing the snapshot header and freeing the extra clusters. There are two specific

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-14 Thread Kevin Wolf
Am 12.05.2014 um 22:27 hat Mike Day geschrieben: > When deleting the last snapshot, copying the resulting snapshot table > currently fails, causing the delete operation to also fail. Fix the > failure by skipping the copy and just writing the snapshot header and > freeing the extra clusters. Do yo

[Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-12 Thread Mike Day
When deleting the last snapshot, copying the resulting snapshot table currently fails, causing the delete operation to also fail. Fix the failure by skipping the copy and just writing the snapshot header and freeing the extra clusters. There are two specific problems in the current code. First is