Re: [Qemu-devel] [PATCH v2] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-26 Thread Casey Leedom
Looks good to me. Casey From: Alex Williamson [alex.william...@redhat.com] Sent: Friday, June 26, 2015 11:01 AM To: Gabriel Laupre Cc: qemu-devel@nongnu.org; m...@redhat.com; jb-gnumli...@wisemo.com; b...@makefile.in; Casey Leedom; Michael Boksanyi; Ani

Re: [Qemu-devel] [PATCH v2] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-26 Thread Gabriel Laupre
Thank you Alex The test which fails in the msix_init() is pba_offset + pba_size > memory_region_size(pba_bar) because pba_offset will be 0x8000 and memory_region_size(pba_bar) equals 0x2000. If we can catch this error before as you suggested I think it is better. I will integrate the changes th

Re: [Qemu-devel] [PATCH v2] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-26 Thread Alex Williamson
On Thu, 2015-06-25 at 17:30 -0700, Gabriel Laupre wrote: > Fix pba_offset initialization value for Chelsio T5 Virtual Function > device. The T5 hardware has a bug in it where it reports a Pending Interrupt > Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead > of the 0x1000 that th

[Qemu-devel] [PATCH v2] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Gabriel Laupre
Fix pba_offset initialization value for Chelsio T5 Virtual Function device. The T5 hardware has a bug in it where it reports a Pending Interrupt Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead of the 0x1000 that the hardware actually uses internally. As the hardware doesn't retu