Re: [Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr

2019-02-11 Thread Wei Yang
On Mon, Feb 11, 2019 at 03:43:07PM +0100, Igor Mammedov wrote: >On Mon, 11 Feb 2019 14:46:29 +0800 >Wei Yang wrote: > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. >> >> Since we have already set up a property PC_DIMM_ADDR_PROP for this >> field and use this mechanism in set_

Re: [Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr

2019-02-11 Thread Igor Mammedov
On Mon, 11 Feb 2019 14:46:29 +0800 Wei Yang wrote: > [get|set]_addr are two counterpart to access PCDIMMDevice.addr. > > Since we have already set up a property PC_DIMM_ADDR_PROP for this > field and use this mechanism in set_addr, it would be more proper to use > the same mechanism in get_addr.

[Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr

2019-02-10 Thread Wei Yang
[get|set]_addr are two counterpart to access PCDIMMDevice.addr. Since we have already set up a property PC_DIMM_ADDR_PROP for this field and use this mechanism in set_addr, it would be more proper to use the same mechanism in get_addr. This patch uses object_property_get_uint() to replace the dir