Re: [Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

2017-12-21 Thread Marcel Apfelbaum
On 21/12/2017 17:08, Marcel Apfelbaum wrote: On 21/12/2017 16:01, Michael S. Tsirkin wrote: On Fri, Dec 08, 2017 at 09:09:06AM -0500, Marcel Apfelbaum wrote: - Original Message - From: "Ladi Prosek" To: qemu-devel@nongnu.org Cc: mar...@redhat.com, ge...@hostfission.com, m...@redhat.

Re: [Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

2017-12-21 Thread Marcel Apfelbaum
On 21/12/2017 16:01, Michael S. Tsirkin wrote: On Fri, Dec 08, 2017 at 09:09:06AM -0500, Marcel Apfelbaum wrote: - Original Message - From: "Ladi Prosek" To: qemu-devel@nongnu.org Cc: mar...@redhat.com, ge...@hostfission.com, m...@redhat.com, "alex williamson" Sent: Friday, Decembe

Re: [Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

2017-12-21 Thread Michael S. Tsirkin
On Fri, Dec 08, 2017 at 09:09:06AM -0500, Marcel Apfelbaum wrote: > > > - Original Message - > > From: "Ladi Prosek" > > To: qemu-devel@nongnu.org > > Cc: mar...@redhat.com, ge...@hostfission.com, m...@redhat.com, "alex > > williamson" > > Sent: Friday, December 8, 2017 8:31:13 AM > >

Re: [Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

2017-12-08 Thread Marcel Apfelbaum
- Original Message - > From: "Ladi Prosek" > To: qemu-devel@nongnu.org > Cc: mar...@redhat.com, ge...@hostfission.com, m...@redhat.com, "alex > williamson" > Sent: Friday, December 8, 2017 8:31:13 AM > Subject: [PATCH v2] msix: don't mask already masked vectors on reset > > msix_mask_

[Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

2017-12-07 Thread Ladi Prosek
msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked to masked. The way it's currently called from msix_reset(), though, may result in calling the release notifier even if the vector is already masked. 1) msix_reset() clea