Re: [Qemu-devel] [PATCH v2] mirror: follow AioContext change gracefully

2016-06-13 Thread Jason J. Herne
On 06/12/2016 02:51 AM, Fam Zheng wrote: ... --- v2: Picked up Stefan's RFC patch and move on towards a more complete fix. Please review! Jason: it would be nice if you could test this version again. It differs from the previous version. No problem. I'll test v3 when it is available. -- --

Re: [Qemu-devel] [PATCH v2] mirror: follow AioContext change gracefully

2016-06-13 Thread Stefan Hajnoczi
On Sun, Jun 12, 2016 at 02:51:04PM +0800, Fam Zheng wrote: > From: Stefan Hajnoczi > > When dataplane is enabled or disabled the drive switches to a new > AioContext. The mirror block job must also move to the new AioContext > so that drive accesses are always made within its AioContext. > > Th

Re: [Qemu-devel] [PATCH v2] mirror: follow AioContext change gracefully

2016-06-13 Thread Stefan Hajnoczi
On Sun, Jun 12, 2016 at 02:51:04PM +0800, Fam Zheng wrote: > @@ -119,7 +121,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret) > qemu_iovec_destroy(&op->qiov); > g_free(op); > > -if (s->waiting_for_io) { > +if (s->waiting_for_io && !s->quiesce_requested) { >

Re: [Qemu-devel] [PATCH v2] mirror: follow AioContext change gracefully

2016-06-13 Thread Paolo Bonzini
On 12/06/2016 08:51, Fam Zheng wrote: > From: Stefan Hajnoczi > > When dataplane is enabled or disabled the drive switches to a new > AioContext. The mirror block job must also move to the new AioContext > so that drive accesses are always made within its AioContext. > > This patch partially

[Qemu-devel] [PATCH v2] mirror: follow AioContext change gracefully

2016-06-11 Thread Fam Zheng
From: Stefan Hajnoczi When dataplane is enabled or disabled the drive switches to a new AioContext. The mirror block job must also move to the new AioContext so that drive accesses are always made within its AioContext. This patch partially achieves that by draining target and source requests t