Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Auger Eric
Hi Eduardo, On 3/7/19 6:26 PM, Eduardo Habkost wrote: > On Thu, Mar 07, 2019 at 10:06:39AM +0100, Eric Auger wrote: >> As NVDIMM support is looming for ARM and SPAPR, let's >> move the acpi_nvdimm_state to the generic machine struct >> instead of duplicating the same code in several machines. >> I

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eduardo Habkost
On Thu, Mar 07, 2019 at 10:06:39AM +0100, Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state. > > nvdimm and nvdimm-

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Philippe Mathieu-Daudé
On 3/7/19 5:58 PM, Eduardo Habkost wrote: > On Thu, Mar 07, 2019 at 04:15:21PM +0100, Auger Eric wrote: >> Hi Philippe, Eduardo, >> >> On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: >>> Hi Eric, Eduardo, >>> >>> On 3/7/19 10:06 AM, Eric Auger wrote: As NVDIMM support is looming for ARM and

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eduardo Habkost
On Thu, Mar 07, 2019 at 04:15:21PM +0100, Auger Eric wrote: > Hi Philippe, Eduardo, > > On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: > > Hi Eric, Eduardo, > > > > On 3/7/19 10:06 AM, Eric Auger wrote: > >> As NVDIMM support is looming for ARM and SPAPR, let's > >> move the acpi_nvdimm_state

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread David Hildenbrand
On 07.03.19 16:36, Philippe Mathieu-Daudé wrote: > On 3/7/19 4:21 PM, David Hildenbrand wrote: >> On 07.03.19 16:15, Auger Eric wrote: >>> Hi Philippe, Eduardo, >>> >>> On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: Hi Eric, Eduardo, On 3/7/19 10:06 AM, Eric Auger wrote: > As

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread David Hildenbrand
On 07.03.19 16:15, Auger Eric wrote: > Hi Philippe, Eduardo, > > On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: >> Hi Eric, Eduardo, >> >> On 3/7/19 10:06 AM, Eric Auger wrote: >>> As NVDIMM support is looming for ARM and SPAPR, let's >>> move the acpi_nvdimm_state to the generic machine struct

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Auger Eric
Hi Philippe, Eduardo, On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: > Hi Eric, Eduardo, > > On 3/7/19 10:06 AM, Eric Auger wrote: >> As NVDIMM support is looming for ARM and SPAPR, let's >> move the acpi_nvdimm_state to the generic machine struct >> instead of duplicating the same code in sev

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Philippe Mathieu-Daudé
On 3/7/19 4:21 PM, David Hildenbrand wrote: > On 07.03.19 16:15, Auger Eric wrote: >> Hi Philippe, Eduardo, >> >> On 3/7/19 11:56 AM, Philippe Mathieu-Daudé wrote: >>> Hi Eric, Eduardo, >>> >>> On 3/7/19 10:06 AM, Eric Auger wrote: As NVDIMM support is looming for ARM and SPAPR, let's mov

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eduardo Habkost
On Thu, Mar 07, 2019 at 10:48:59AM +0100, Igor Mammedov wrote: [...] > > +static void machine_set_nvdimm_persistence(Object *obj, const char *value, > > + Error **errp) > > +{ > > +MachineState *ms = MACHINE(obj); > > +AcpiNVDIMMState *nvdimms_s

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Philippe Mathieu-Daudé
Hi Eric, Eduardo, On 3/7/19 10:06 AM, Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state. > > nvdimm and nvdimm-per

Re: [Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Igor Mammedov
On Thu, 7 Mar 2019 10:06:39 +0100 Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state. > > nvdimm and nvdimm-persi

[Qemu-devel] [PATCH v2] machine: Move acpi_nvdimm_state into struct MachineState

2019-03-07 Thread Eric Auger
As NVDIMM support is looming for ARM and SPAPR, let's move the acpi_nvdimm_state to the generic machine struct instead of duplicating the same code in several machines. It is also renamed into nvdimms_state. nvdimm and nvdimm-persistence become generic machine options. We also add a description fo