Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Peter Xu
On Wed, Mar 01, 2017 at 02:32:34PM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 11:59 AM, Peter Xu wrote: > >On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: > >>On 03/01/2017 11:18 AM, Peter Xu wrote: > >>>On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: > O

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Peter Xu
On Wed, Mar 01, 2017 at 12:14:21PM +0800, Jason Wang wrote: > On 2017年03月01日 11:23, Michael S. Tsirkin wrote: [...] > >While I agree this fixes the specific problem, we have the ordering > >issue in many other places. > > Yes, just post a fix for virtio-pci with IOMMU. With this fix, we meet the

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Marcel Apfelbaum
On 03/01/2017 11:59 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 11:18 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: [...] Hi Jason, I am not saying we

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Peter Xu
On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 11:18 AM, Peter Xu wrote: > >On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: > >>On 03/01/2017 06:14 AM, Jason Wang wrote: > > > >[...] > > > >>Hi Jason, > >> > >>I am not saying we don't need to cre

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Marcel Apfelbaum
On 03/01/2017 11:18 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: [...] Hi Jason, I am not saying we don't need to create the IOMMU before some other device, I just don't think that the command line order shou

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Marcel Apfelbaum
On 03/01/2017 10:43 AM, Jason Wang wrote: On 2017年03月01日 15:03, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfe

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Peter Xu
On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 06:14 AM, Jason Wang wrote: [...] > Hi Jason, > > I am not saying we don't need to create the IOMMU before some other device, > I just don't think that the command line order should matter to user. > > BTW, are yo

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-03-01 Thread Jason Wang
On 2017年03月01日 15:03, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: On 02/24/2017 06:29 AM, Peter

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-28 Thread Marcel Apfelbaum
On 03/01/2017 06:14 AM, Jason Wang wrote: On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: On 02/24/2017 06:29 AM, Peter Xu wrote: Intel vIOMMU devices are created with

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-28 Thread Jason Wang
On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: On 02/24/2017 06:29 AM, Peter Xu wrote: Intel vIOMMU devices are created with "-device" parameter, while here actually w

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-28 Thread Michael S. Tsirkin
On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: > On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: > > On 02/24/2017 06:29 AM, Peter Xu wrote: > > >Intel vIOMMU devices are created with "-device" parameter, while here > > >actually we need to make sure the dmar device be

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-28 Thread Peter Xu
On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: > On 02/24/2017 06:29 AM, Peter Xu wrote: > >Intel vIOMMU devices are created with "-device" parameter, while here > >actually we need to make sure the dmar device be created before other > >PCI devices (like vfio-pci) so that we kno

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-28 Thread Marcel Apfelbaum
On 02/24/2017 06:29 AM, Peter Xu wrote: Intel vIOMMU devices are created with "-device" parameter, while here actually we need to make sure the dmar device be created before other PCI devices (like vfio-pci) so that we know iommu_fn will be setup correctly before realizations of those PCI devices

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-24 Thread Pankaj Gupta
> On Fri, Feb 24, 2017 at 01:35:10AM -0500, Pankaj Gupta wrote: > > > > > > > > On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > > > > Hello Peter, > > > > > > Hi, Pankaj! > > > > > > > > > > > This solution looks to check dependency of 'vfio-pci' over > > > > 'intel-iommu' > >

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-23 Thread Peter Xu
On Fri, Feb 24, 2017 at 01:35:10AM -0500, Pankaj Gupta wrote: > > > > > On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > > > Hello Peter, > > > > Hi, Pankaj! > > > > > > > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > > > before 'intel-iommu' is no

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-23 Thread Pankaj Gupta
> > On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > > Hello Peter, > > Hi, Pankaj! > > > > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > > before 'intel-iommu' is not initialized. > > > > Overall it looks good to me, just a small nit below. > >

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-23 Thread Peter Xu
On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > Hello Peter, Hi, Pankaj! > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > before 'intel-iommu' is not initialized. > > Overall it looks good to me, just a small nit below. > > > > > Intel vIOMMU dev

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-23 Thread Pankaj Gupta
Hello Peter, This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' before 'intel-iommu' is not initialized. Overall it looks good to me, just a small nit below. > > Intel vIOMMU devices are created with "-device" parameter, while here > actually we need to make sure the dmar

[Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

2017-02-23 Thread Peter Xu
Intel vIOMMU devices are created with "-device" parameter, while here actually we need to make sure the dmar device be created before other PCI devices (like vfio-pci) so that we know iommu_fn will be setup correctly before realizations of those PCI devices (it is sensible that PCI device fetch the