Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Bin Meng
On Thu, Aug 8, 2019 at 3:01 PM Philippe Mathieu-Daudé wrote: > > On 8/8/19 8:36 AM, Bin Meng wrote: > > On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi, > >> > >> On 8/8/19 6:44 AM, Bin Meng wrote: > >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several > >

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-08 Thread Philippe Mathieu-Daudé
On 8/8/19 8:36 AM, Bin Meng wrote: > On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé > wrote: >> >> Hi, >> >> On 8/8/19 6:44 AM, Bin Meng wrote: >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several >>> compilation errors in DB_PRINT(). Fix them. >>> >>> Signed-off-by: Bin Meng >>

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-07 Thread Bin Meng
On Thu, Aug 8, 2019 at 1:21 PM Philippe Mathieu-Daudé wrote: > > Hi, > > On 8/8/19 6:44 AM, Bin Meng wrote: > > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > > compilation errors in DB_PRINT(). Fix them. > > > > Signed-off-by: Bin Meng > > > > --- > > > > Changes in v2: > > Please

Re: [Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-07 Thread Philippe Mathieu-Daudé
Hi, On 8/8/19 6:44 AM, Bin Meng wrote: > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > compilation errors in DB_PRINT(). Fix them. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: Please don't reply to previous version, post as a new thread (it is harder to notice your ne

[Qemu-devel] [PATCH v2] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-07 Thread Bin Meng
When CADENCE_GEM_ERR_DEBUG is turned on, there are several compilation errors in DB_PRINT(). Fix them. Signed-off-by: Bin Meng --- Changes in v2: - use HWADDR_PRIx instead of TARGET_FMT_plx for consistency - use 'z' modifier to print sizeof(..) hw/net/cadence_gem.c | 7 --- 1 file changed