Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread mike
On 10/17/2013 04:14 PM, Stefan Hajnoczi wrote: On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote: Change to v1: remove '[not inserted]' line instead of adding '\n' Output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] R

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread mike
On 10/17/2013 04:11 PM, Kevin Wolf wrote: Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben: Change to v1: remove '[not inserted]' line instead of adding '\n' Please put such notes for reviewers below the --- line, so that git am automatically removes them and they don't end up in the git

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote: > Change to v1: > remove '[not inserted]' line instead of adding '\n' > > Output of 'info block' > > scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) > [not inserted] > scsi0-cd2: [not inserted] > Removable device: not locked, tray cl

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread Kevin Wolf
Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben: > Change to v1: > remove '[not inserted]' line instead of adding '\n' Please put such notes for reviewers below the --- line, so that git am automatically removes them and they don't end up in the git commit message. > Output of 'info block'

[Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-16 Thread Mike Qiu
Change to v1: remove '[not inserted]' line instead of adding '\n' Output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] Removable device: not locked, tray closed floppy0: [not inserted] Removable device: not locked, tray close