Re: [Qemu-devel] [PATCH v2] gdbstub: Implement Xfer:auxv:read

2015-07-29 Thread Bhushan Attarde
Hi Peter, Thanks for the review. >> if ((ptr != NULL && addr > len) > ||(ptr == NULL && addr > total_len)) { >> This if is rather confusing. Why should ptr == or != NULL make a difference? >> What is ptr == NULL actually encoding? I think it is enough just to check if (addr > total_len) w

Re: [Qemu-devel] [PATCH v2] gdbstub: Implement Xfer:auxv:read

2015-07-28 Thread Peter Maydell
On 28 July 2015 at 11:58, Bhushan Attarde wrote: > Implementation of "Xfer:auxv:read" to provide auxiliary vector information > to clients which relies on it. > > For example: AT_ENTRY in auxiliary vector provides the entry point > information. > Client can use this information to compare it with

[Qemu-devel] [PATCH v2] gdbstub: Implement Xfer:auxv:read

2015-07-28 Thread Bhushan Attarde
Implementation of "Xfer:auxv:read" to provide auxiliary vector information to clients which relies on it. For example: AT_ENTRY in auxiliary vector provides the entry point information. Client can use this information to compare it with entry point mentioned in executable to calculate load offset