Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-03-01 Thread Gonglei
On 2015/3/1 18:06, Paolo Bonzini wrote: > > > On 28/02/2015 17:47, Stefan Weil wrote: >>> Reviewed-by: Paolo Bonzini >> >> Which one of the two patch variants did you review? >> >> I suggest using Michael's version (only one g_free as early as >> possible). For that variant, my review may be add

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-03-01 Thread Paolo Bonzini
On 28/02/2015 17:47, Stefan Weil wrote: >> Reviewed-by: Paolo Bonzini > > Which one of the two patch variants did you review? > > I suggest using Michael's version (only one g_free as early as > possible). For that variant, my review may be added: > > Reviewed-by: Stefan Weil I also referre

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread Stefan Weil
Am 28.02.2015 um 17:40 schrieb Paolo Bonzini: On 28/02/2015 11:13, Michael Tokarev wrote: 28.02.2015 13:08, arei.gong...@huawei.com пишет: From: Gonglei Signed-off-by: Gonglei --- v2: fix compilation complaint. (mjt) --- hw/ppc/e500.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread Paolo Bonzini
On 28/02/2015 11:13, Michael Tokarev wrote: > 28.02.2015 13:08, arei.gong...@huawei.com пишет: >> From: Gonglei >> >> Signed-off-by: Gonglei >> --- >> v2: fix compilation complaint. (mjt) >> --- >> hw/ppc/e500.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/ppc/e500.c b/hw/p

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread Michael Tokarev
28.02.2015 13:18, Gonglei wrote: > On 2015/2/28 18:13, Michael Tokarev wrote: [] >> How about this? >> > It's ok on function, but seems oddly, isn't it? I don't see anything odd in it. The `filename' variable is only used as an argument for load_device_tree() function and is not used anywhwere el

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread Gonglei
On 2015/2/28 18:13, Michael Tokarev wrote: > 28.02.2015 13:08, arei.gong...@huawei.com пишет: >> From: Gonglei >> >> Signed-off-by: Gonglei >> --- >> v2: fix compilation complaint. (mjt) >> --- >> hw/ppc/e500.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/ppc/e500.c b/hw/ppc/

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread Michael Tokarev
28.02.2015 13:08, arei.gong...@huawei.com пишет: > From: Gonglei > > Signed-off-by: Gonglei > --- > v2: fix compilation complaint. (mjt) > --- > hw/ppc/e500.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c > index 7e17d18..c060b50 100644 > --- a/hw/ppc

[Qemu-devel] [PATCH v2] e500: fix memory leak

2015-02-28 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- v2: fix compilation complaint. (mjt) --- hw/ppc/e500.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 7e17d18..c060b50 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -309,8 +309,10 @@ static int ppce500_load_