On 23 January 2014 21:52, Xin Tong wrote:
> Richard. I am sorry. I thought the patch submitter put review-bys
> themselves. How do i get a reviewed-by ?
You submit your patch, you fix any issues people raise, and
you resubmit the fixed version. Eventually when all the problems
have been corrected
Richard. I am sorry. I thought the patch submitter put review-bys
themselves. How do i get a reviewed-by ?
Xin
On Thu, Jan 23, 2014 at 3:47 PM, Richard Henderson wrote:
> On 01/23/2014 11:49 AM, Xin Tong wrote:
>> Reviewed-by: Richard Henderson
>> Signed-off-by: Xin Tong
>
> I did not give you
On 01/23/2014 11:49 AM, Xin Tong wrote:
> Reviewed-by: Richard Henderson
> Signed-off-by: Xin Tong
I did not give you a Reviewed-by. That implies that I
approve of the patch as written, or with minor tweaks.
But you can't just add this on your own.
r~
On Fri, Jan 24, 2014 at 1:29 AM, Xin Tong wrote:
>>> +/* swap the 2 given TLB entries as well as their corresponding IOTLB */
>>> +inline void swap_tlb(CPUTLBEntry *te, CPUTLBEntry *se, hwaddr *iote,
>>> + hwaddr *iose)
>>> +{
>>> + hwaddr iotmp;
>>> + CPUTLBEntry t;
>>> +
Hi Max
Thank you for taking the time to review my patch
On Thu, Jan 23, 2014 at 2:44 PM, Max Filippov wrote:
> Hi Xin,
>
> On Thu, Jan 23, 2014 at 11:49 PM, Xin Tong wrote:
>
> [...]
>
>> diff --git a/cputlb.c b/cputlb.c
>> index b533f3f..03a048a 100644
>> --- a/cputlb.c
>> +++ b/cputlb.c
>> @@
Hi Xin,
On Thu, Jan 23, 2014 at 11:49 PM, Xin Tong wrote:
[...]
> diff --git a/cputlb.c b/cputlb.c
> index b533f3f..03a048a 100644
> --- a/cputlb.c
> +++ b/cputlb.c
> @@ -34,6 +34,22 @@
> /* statistics */
> int tlb_flush_count;
>
> +/* swap the 2 given TLB entries as well as their correspondi
Attaching data in excel which could not be sent with the patch at the same time.
On Thu, Jan 23, 2014 at 1:49 PM, Xin Tong wrote:
> This patch adds a victim TLB to the QEMU system mode TLB.
>
> QEMU system mode page table walks are expensive. Taken by running QEMU
> qemu-system-x86_64 system mode
This patch adds a victim TLB to the QEMU system mode TLB.
QEMU system mode page table walks are expensive. Taken by running QEMU
qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a
4-level page tables in guest Linux OS takes ~450 X86 instructions on
average.
QEMU system mode TL
