Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 16:54, Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used > anymore on Linux. Leave non-Linux unchanged because one developer system > still uses it. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Signed-off-by: Olaf Hering > --

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 10:04:03 -0500 schrieb Eric Blake : > avoid g_realloc_n()? I guess there is some global header for this, to prevent further accidents? extern void *g_realloc_n_can_not_be_used(void); #define g_realloc_n(a,b,c) g_realloc_n_can_not_be_used() Olaf pgp_y86xwZs_3.pgp Descripti

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 10:04:03 -0500 schrieb Eric Blake : > Rather than hacking configure, why not fix util/vfio-helpers.c to avoid > g_realloc_n()? We've done it before; see commit 071d405 I can not really test it, this variant may work: --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -52

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180418145443.6332-1-o...@aepfle.de Subject: [Qemu-devel] [PATCH v2] configure

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Eric Blake
On 04/18/2018 09:54 AM, Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used > anymore on Linux. Leave non-Linux unchanged because one developer system > still uses it. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Signed-off-by: Olaf Hering >

[Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore on Linux. Leave non-Linux unchanged because one developer system still uses it. Fixes commit 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Olaf Hering --- configure | 6 +- 1 file changed, 5 insertions(