Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target

2013-07-17 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:57:37PM +0800, Fam Zheng wrote: > s->qcow and s->qcow_filename are allocated but not freed on error. Fix the > possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of > bdrv_create() and also the one of enable_write_target(). > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target

2013-07-17 Thread Laszlo Ersek
On 07/17/13 11:57, Fam Zheng wrote: > s->qcow and s->qcow_filename are allocated but not freed on error. Fix the > possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of > bdrv_create() and also the one of enable_write_target(). > > Signed-off-by: Fam Zheng > --- > > v2:

[Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target

2013-07-17 Thread Fam Zheng
s->qcow and s->qcow_filename are allocated but not freed on error. Fix the possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of bdrv_create() and also the one of enable_write_target(). Signed-off-by: Fam Zheng --- v2: Fix leak of s->qcow_filename, propagate returen valu