Re: [Qemu-devel] [PATCH v2] block: change variable names in BlockDriverState

2017-06-09 Thread Manos Pitsidianakis
On Fri, Jun 09, 2017 at 10:41:13AM +0100, Stefan Hajnoczi wrote: On Fri, Jun 09, 2017 at 02:22:55AM +0300, Manos Pitsidianakis wrote: diff --git a/hw/ide/core.c b/hw/ide/core.c index 0b48b64..1a74339 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -416,16 +416,16 @@ static void ide_issue_trim_

Re: [Qemu-devel] [PATCH v2] block: change variable names in BlockDriverState

2017-06-09 Thread Stefan Hajnoczi
On Fri, Jun 09, 2017 at 02:22:55AM +0300, Manos Pitsidianakis wrote: > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 0b48b64..1a74339 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -416,16 +416,16 @@ static void ide_issue_trim_cb(void *opaque, int ret) > /* 6-byte LBA

[Qemu-devel] [PATCH v2] block: change variable names in BlockDriverState

2017-06-08 Thread Manos Pitsidianakis
Change the 'int count' parameter in *pwrite_zeros, *pdiscard related functions (and some others) to 'int bytes', as they both refer to bytes. This helps with code legibility. Signed-off-by: Manos Pitsidianakis --- block/blkdebug.c | 36 +++ block/blkrepl