Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-30 Thread Zhi Yong Wu
On Fri, Oct 28, 2011 at 01:31:20PM +0100, Stefan Hajnoczi wrote: >Subject: Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2 >From: Stefan Hajnoczi >To: Zhi Yong Wu >Cc: Paolo Bonzini , Lucas Meneghel Rodrigues > , aligu...@us.ibm.com, Stefan Hajnoczi > , qemu-devel@nongnu.or

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 02:31 PM, Stefan Hajnoczi wrote: Zhi Yong: We were just talking about converting devices to aio. If you have time to do that for fdc, sd, or any other synchronous API users in hw/ that would be helpful. Please let us know which device you are refactoring so we don't duplicate work

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 1:29 PM, Kevin Wolf wrote: > Am 28.10.2011 13:50, schrieb Paolo Bonzini: >> On 10/28/2011 01:33 PM, Kevin Wolf wrote: >>> I'm afraid that we can only avoid things like this reliably if we >>> convert all devices to be direct users of AIO/coroutines. The current >>> block la

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 13:50, schrieb Paolo Bonzini: > On 10/28/2011 01:33 PM, Kevin Wolf wrote: >> I'm afraid that we can only avoid things like this reliably if we >> convert all devices to be direct users of AIO/coroutines. The current >> block layer infrastructure doesn't emulate the behaviour of bdrv_r

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Cleber Rosa
On 10/28/2011 08:33 AM, Kevin Wolf wrote: Am 27.10.2011 16:32, schrieb Kevin Wolf: Am 27.10.2011 16:15, schrieb Kevin Wolf: Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: Am 19.09.2011 16:37, schrieb Frediano Ziglio: Now that iothrea

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 01:33 PM, Kevin Wolf wrote: I'm afraid that we can only avoid things like this reliably if we convert all devices to be direct users of AIO/coroutines. The current block layer infrastructure doesn't emulate the behaviour of bdrv_read accurately as bottom halves can be run in the nes

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 13:33, schrieb Kevin Wolf: > Am 27.10.2011 16:32, schrieb Kevin Wolf: >> Am 27.10.2011 16:15, schrieb Kevin Wolf: >>> Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: > Am 19.09.2011 16:37, schrieb Frediano Ziglio:

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 27.10.2011 16:32, schrieb Kevin Wolf: > Am 27.10.2011 16:15, schrieb Kevin Wolf: >> Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: >>> On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 16:15, schrieb Kevin Wolf: > Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: >> On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: >>> Am 19.09.2011 16:37, schrieb Frediano Ziglio: Now that iothread is always compiled sending a signal seems only an additional step. Th

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: > On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: >> Am 19.09.2011 16:37, schrieb Frediano Ziglio: >>> Now that iothread is always compiled sending a signal seems only an >>> additional step. This patch also avoid writing to two pipe (one fr

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: > Am 19.09.2011 16:37, schrieb Frediano Ziglio: > > Now that iothread is always compiled sending a signal seems only an > > additional step. This patch also avoid writing to two pipe (one from signal > > and one in qemu_service_io). > > >

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-27 Thread Kevin Wolf
Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Work with kvm enabled or disabled. strace output is more readable (le

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 05:11 PM, Kevin Wolf wrote: > I think it is possible to go a step further, turn > posix_aio_process_queue into a bottom half and get rid of the pipe > altogether. This in turn would remove the only real user of > io_process_queue in qemu_aio_set_fd_handler. However, this is al

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending a signal seems only an > additional step. This patch also avoid writing to two pipe (one from signal > and one in qemu_service_io). > > Work with kvm enabled or disabled. strace output is more readable (le

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Kevin Wolf
Am 19.09.2011 17:02, schrieb Paolo Bonzini: > On 09/19/2011 04:37 PM, Frediano Ziglio wrote: >> Now that iothread is always compiled sending a signal seems only an >> additional step. This patch also avoid writing to two pipe (one from signal >> and one in qemu_service_io). >> >> Work with kvm enab

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Paolo Bonzini
On 09/19/2011 04:37 PM, Frediano Ziglio wrote: Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less sys

[Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-09-19 Thread Frediano Ziglio
Now that iothread is always compiled sending a signal seems only an additional step. This patch also avoid writing to two pipe (one from signal and one in qemu_service_io). Work with kvm enabled or disabled. strace output is more readable (less syscalls). Signed-off-by: Frediano Ziglio --- cpu