Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
On Tue, 09/27 13:15, Kevin Wolf wrote: > Am 27.09.2016 um 13:04 hat Fam Zheng geschrieben: > > On Tue, 09/27 17:33, Fam Zheng wrote: > > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > > commit', but didn't turn on the "unmap" in the active commit job. This > > > patch fixe

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Kevin Wolf
Am 27.09.2016 um 13:04 hat Fam Zheng geschrieben: > On Tue, 09/27 17:33, Fam Zheng wrote: > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > commit', but didn't turn on the "unmap" in the active commit job. This > > patch fixes that so that zeroed clusters in top image can b

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
On Tue, 09/27 17:33, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use ca

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
On Tue, 09/27 17:33, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use ca

[Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overlay is created and f