Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 24, 2015 at 09:17:38AM +0800, Fam Zheng wrote: > Alberto saw that this patch also fixes the odd behavior: block jobs, which > need > to R/W a throttled BDS, will not make progress if VCPU is not running. If we > don't consider this as a bug, we should document the inconsistency > (con

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Fam Zheng
On Mon, 03/23 14:28, Stefan Hajnoczi wrote: > On Mon, Mar 23, 2015 at 1:58 PM, Paolo Bonzini wrote: > > On 23/03/2015 14:56, Stefan Hajnoczi wrote: > >> On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: > >>> Currently, throttle timers won't make any progress when VCPU is not > >>> runnin

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 16:00, Stefan Hajnoczi wrote: > On Mon, Mar 23, 2015 at 2:49 PM, Paolo Bonzini wrote: >> On 23/03/2015 15:28, Stefan Hajnoczi wrote: >>> I'd like to know what problems exactly this patch fixes. The test >>> case for throttling actually relies on the virtual clock so it can be >>>

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 2:49 PM, Paolo Bonzini wrote: > On 23/03/2015 15:28, Stefan Hajnoczi wrote: >> I'd like to know what problems exactly this patch fixes. The test >> case for throttling actually relies on the virtual clock so it can be >> stepped deterministically. What other legitimate ca

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 15:28, Stefan Hajnoczi wrote: > I'd like to know what problems exactly this patch fixes. The test > case for throttling actually relies on the virtual clock so it can be > stepped deterministically. What other legitimate cases are there > where throttling is used outside a running

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 1:58 PM, Paolo Bonzini wrote: > On 23/03/2015 14:56, Stefan Hajnoczi wrote: >> On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: >>> Currently, throttle timers won't make any progress when VCPU is not >>> running, which would stall the request queue in utils, qtest

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 14:56, Stefan Hajnoczi wrote: > On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: >> Currently, throttle timers won't make any progress when VCPU is not >> running, which would stall the request queue in utils, qtest, vm >> suspending, and live migration without special han

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration without special handling. > > For example in bdrv_drain_all, all requ

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Alberto Garcia
On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration without special handling. > > For example in bdrv_drain_all, all requ

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 06:24, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration without special handling. > > For example in bdrv_drain_all, all requests are resumed im

[Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-22 Thread Fam Zheng
Currently, throttle timers won't make any progress when VCPU is not running, which would stall the request queue in utils, qtest, vm suspending, and live migration without special handling. For example in bdrv_drain_all, all requests are resumed immediately without taking throttling limit into acc