02.07.2015 21:43, Dmitry Osipenko пишет:
4) re-load TIMER_LOAD
And 4-th step can be omitted.
Anyway, I already sent patches fixing this and IT issues.
--
Dmitry
02.07.2015 21:43, Dmitry Osipenko пишет:
02.07.2015 21:09, Peter Maydell пишет:
TIMER_CONTROL_IT_ENABLE) to TIMER_CONTROL < it won't start, bug
s/it won't start/it won't start periodic/
--
Dmitry
02.07.2015 21:09, Peter Maydell пишет:
On 2 July 2015 at 18:52, Dmitry Osipenko wrote:
02.07.2015 20:34, Peter Maydell пишет:
This will now cause us to do the "reload the timer"
logic if you write a 1 to the control bit when it was
already 1, which we didn't do before.
The logic I suggested
On 2 July 2015 at 18:52, Dmitry Osipenko wrote:
> 02.07.2015 20:34, Peter Maydell пишет:
>>
>>
>> This will now cause us to do the "reload the timer"
>> logic if you write a 1 to the control bit when it was
>> already 1, which we didn't do before.
>>
>> The logic I suggested in my previous review
02.07.2015 20:34, Peter Maydell пишет:
This will now cause us to do the "reload the timer"
logic if you write a 1 to the control bit when it was
already 1, which we didn't do before.
The logic I suggested in my previous review
comment gets this right...
-- PMM
The problem with code you sugg
02.07.2015 20:34, Peter Maydell пишет:
On 2 July 2015 at 18:20, Dmitry Osipenko wrote:
Timer, running in periodic mode, can't be stopped or coming one-shot tick
won't be canceled because timer control code just doesn't handle timer
disabling. Fix it by deleting timer if enable bit isn't set.
S
On 2 July 2015 at 18:20, Dmitry Osipenko wrote:
> Timer, running in periodic mode, can't be stopped or coming one-shot tick
> won't be canceled because timer control code just doesn't handle timer
> disabling. Fix it by deleting timer if enable bit isn't set.
>
> Signed-off-by: Dmitry Osipenko
>
Timer, running in periodic mode, can't be stopped or coming one-shot tick
won't be canceled because timer control code just doesn't handle timer
disabling. Fix it by deleting timer if enable bit isn't set.
Signed-off-by: Dmitry Osipenko
---
v2: Avoid calling timer_del() if the timer was already
