Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-12 Thread Peter Maydell
On 11 March 2014 12:29, Peter Maydell wrote: > On 10 March 2014 19:56, Michael S. Tsirkin wrote: >> casting an unaligned address to e.g. >> uint32_t can trigger undefined behaviour in C. >> Replace cast + assignment with memcpy. >> >> Reported-by: Peter Maydell >> Signed-off-by: Michael S. Tsirk

Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-11 Thread Michael S. Tsirkin
On Tue, Mar 11, 2014 at 12:29:05PM +, Peter Maydell wrote: > On 10 March 2014 19:56, Michael S. Tsirkin wrote: > > casting an unaligned address to e.g. > > uint32_t can trigger undefined behaviour in C. > > Replace cast + assignment with memcpy. > > > > Reported-by: Peter Maydell > > Signed-o

Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-11 Thread Peter Maydell
On 10 March 2014 19:56, Michael S. Tsirkin wrote: > casting an unaligned address to e.g. > uint32_t can trigger undefined behaviour in C. > Replace cast + assignment with memcpy. > > Reported-by: Peter Maydell > Signed-off-by: Michael S. Tsirkin This does fix the clang warnings. > -/* Get poin

[Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-10 Thread Michael S. Tsirkin
casting an unaligned address to e.g. uint32_t can trigger undefined behaviour in C. Replace cast + assignment with memcpy. Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin --- Changes from v1: no need to export bswap_le anymore hw/i386/acpi-build.c | 31 ---