Re: [Qemu-devel] [PATCH v2] Introduce attributes to qemu timer subsystem

2018-10-16 Thread Paolo Bonzini
On 16/10/2018 15:03, Artem Pisarenko wrote: > +if (!timer_list) { > +timer_list = main_loop_tlg.tl[type]; > +} > +timer_init_full(ts, timer_list, scale, attributes, cb, opaque); Please move this "if" to timer_init_full, so that here you can just pass timer_list. timer_init_ful

[Qemu-devel] [PATCH v2] Introduce attributes to qemu timer subsystem

2018-10-16 Thread Artem Pisarenko
Attributes are simple flags, associated with individual timers for their whole lifetime. They intended to be used to mark individual timers for special handling by various qemu features operating at qemu core level. New/init functions family in timer interface updated and their comments improved