Re: [Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-18 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 02:39:21PM +, Stefan Hajnoczi wrote: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > HACKING | 18 ++

Re: [Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-16 Thread Eric Blake
On 11/16/2016 08:39 AM, Stefan Hajnoczi wrote: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > HACKING |

[Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-16 Thread Stefan Hajnoczi
It was not obvious to me why "qemu/osdep.h" must be the first #include. This documents the rationale and the overall #include order. Cc: Fam Zheng Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Stefan Hajnoczi --- HACKING | 18 ++ 1 file changed, 18 insertions(+) diff --