Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-11 Thread Jan Kiszka
On 2011-09-10 16:37, Bharata B Rao wrote: > On Fri, Sep 9, 2011 at 10:44 PM, Anthony Liguori > wrote: >> >> This breaks the build: >> >> CCi386-linux-user/helper.o >> /home/anthony/git/qemu/target-i386/helper.c: In function ‘cpu_x86_init’: >> /home/anthony/git/qemu/target-i386/helper.c:1260:

Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-10 Thread Bharata B Rao
On Fri, Sep 9, 2011 at 10:44 PM, Anthony Liguori wrote: > > This breaks the build: > >  CC    i386-linux-user/helper.o > /home/anthony/git/qemu/target-i386/helper.c: In function ‘cpu_x86_init’: > /home/anthony/git/qemu/target-i386/helper.c:1260:47: error: ‘smp_cpus’ > undeclared (first use in this

Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-09 Thread Anthony Liguori
On 09/08/2011 12:33 AM, bharata@gmail.com wrote: From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest

Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-08 Thread Jan Kiszka
On 2011-09-08 07:33, bharata@gmail.com wrote: > From: Bharata B Rao > > apic id returned to guest kernel in ebx for cpuid(function=1) depends on > CPUX86State->cpuid_apic_id which gets populated after the cpuid information > is cached in the host kernel. This results in broken CPU topology in

[Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-07 Thread bharata . rao
From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest. Fix this by setting cpuid_apic_id before cpuid info