Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 14:10:01 +0200 Greg Kurz wrote: > On Wed, 9 Aug 2017 13:06:14 +0200 > Cornelia Huck wrote: > > Should the condition be VIRTFS && (VIRTIO || XEN), then? > > That's what I was beginning to think as well :) OK, here's what should work: - fsdev/Makefile.objs needs to check f

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Greg Kurz
On Wed, 9 Aug 2017 13:06:14 +0200 Cornelia Huck wrote: > On Wed, 9 Aug 2017 11:47:05 +0200 > Greg Kurz wrote: > > > On Wed, 9 Aug 2017 10:27:37 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > > Thomas Huth wrote: > > > > > But thinking about this again, I

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 11:47:05 +0200 Greg Kurz wrote: > On Wed, 9 Aug 2017 10:27:37 +0200 > Cornelia Huck wrote: > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > But thinking about this again, I wonder whether it would be enough to > > > simply check for CONFIG_VIRTIO=y here

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:47:18 +0100 Peter Maydell wrote: > On 9 August 2017 at 10:07, Thomas Huth wrote: > > While virtio-pci and virtio-ccw seem to require separate dedicated > > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > > virtio-mmio seems to work different. As far as I ca

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Greg Kurz
On Wed, 9 Aug 2017 10:27:37 +0200 Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > > > On 09.08.2017 09:17, Cornelia Huck wrote: > > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > > on CONFIG_VIRTFS and on the presence of an appropri

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Peter Maydell
On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > virtio-mmio seems to work different. As far as I can see, there are no > dedicated virtio-xxx-mmio devices in the co

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Peter Maydell
On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, You don't *have* to use the dedicated virtio-foo-pci device; if you like you can manually plug together the virtio-pc

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:24:13 +0100 "Daniel P. Berrange" wrote: > On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > > On 09.08.2017 10:27, Cornelia Huck wrote: > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > > Thomas Huth wrote: > > > > > >> On 09.08.2017 09:17, Cornelia Huck wrote:

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Daniel P. Berrange
On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > >>

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 11:07:38 +0200 Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > >>>

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Thomas Huth
On 09.08.2017 10:27, Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > >> On 09.08.2017 09:17, Cornelia Huck wrote: >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend >>> on CONFIG_VIRTFS and on the presence of an appropriate virtio transport >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Thomas Huth
On 09.08.2017 09:17, Cornelia Huck wrote: > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > device. > > Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for > CONFIG_VIRTFS && (CONFIG_VIRTIO

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
On Wed, 9 Aug 2017 10:23:04 +0200 Thomas Huth wrote: > On 09.08.2017 09:17, Cornelia Huck wrote: > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > > device. > > > > Let's introduce CONFIG_VIRTIO

[Qemu-devel] [PATCH v2] 9pfs: fix dependencies

2017-08-09 Thread Cornelia Huck
Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend on CONFIG_VIRTFS and on the presence of an appropriate virtio transport device. Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for CONFIG_VIRTFS && (CONFIG_VIRTIO_PCI || CONFIG_VIRTIO_CCW). Signed-off-by: Cornelia H