Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-13 Thread Pradeep Jagadeesh
-Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Tuesday, September 13, 2016 2:30 PM To: Pradeep Jagadeesh Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org; Claudio Fontana; Eric Blake Subject: Re: [PATCH v2] 9pfs: add support for IO limits

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-13 Thread Greg Kurz
On Tue, 13 Sep 2016 09:17:49 + Pradeep Jagadeesh wrote: > Hi Greg, > > Replies inline > > Cheers, > Pradeep > -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Tuesday, September 13, 2016 10:52 AM > To: Pradeep Jagadeesh > Cc: Pradeep Jagadeesh; Aneesh Kumar K.V;

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-13 Thread Pradeep Jagadeesh
Hi Greg, Replies inline Cheers, Pradeep -Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Tuesday, September 13, 2016 10:52 AM To: Pradeep Jagadeesh Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org; Claudio Fontana; Eric Blake Subject: Re: [

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-13 Thread Greg Kurz
On Mon, 12 Sep 2016 16:08:43 + Pradeep Jagadeesh wrote: > Replies inline Greg. > > Thanks & Regards, > Pradeep > Hi Pradeep, > -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Monday, September 12, 2016 4:19 PM > To: Pradeep Jagadeesh > Cc: Pradeep Jagadeesh;

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-12 Thread Pradeep Jagadeesh
Replies inline Greg. Thanks & Regards, Pradeep -Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Monday, September 12, 2016 4:19 PM To: Pradeep Jagadeesh Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org; Claudio Fontana; Eric Blake Subject: R

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-12 Thread Pradeep Jagadeesh
Hi Greg, Thanks for looking into the patch. Please look at the replies inline. Regards, Pradeep -Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Friday, September 09, 2016 5:29 PM To: Pradeep Jagadeesh Cc: Aneesh Kumar K.V; Pradeep Jagadeesh; Alberto Garcia; qemu-devel@n

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-12 Thread Greg Kurz
On Mon, 12 Sep 2016 12:52:55 + Pradeep Jagadeesh wrote: > Hi Greg, > > Thanks for looking into the patch. Please look at the replies inline. > > Regards, > Pradeep > Hi Pradeep, Remarks and answers below. Cheers. -- Greg > -Original Message- > From: Greg Kurz [mailto:gr...@kao

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Greg Kurz
On Fri, 9 Sep 2016 17:29:16 +0200 Greg Kurz wrote: > > +bool throttle9p_get_io_limits_state(FsThrottle *fst) > > The name looks a bit strange, since this helper simply returns a boolean flag. > I guess throttle9p_enabled() is enough. > > > +{ > > + > > +return fst->io_limits_enabled; > > +

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Alberto Garcia
On Fri 09 Sep 2016 05:29:16 PM CEST, Greg Kurz wrote: > On Fri, 9 Sep 2016 05:10:27 -0400 > Pradeep Jagadeesh wrote: > >> Uses throttling APIs to limit I/O bandwidth and number of operations on the >> devices which use 9p-local driver. >> >> Signed-off-by: Pradeep Jagadeesh >> --- > > Hi Prade

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Greg Kurz
On Fri, 9 Sep 2016 05:10:27 -0400 Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > devices which use 9p-local driver. > > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, Please find some remarks below. I haven't dived deep enough to

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Claudio Fontana
Hi Pradeep, two comment below: On 09.09.2016 11:10, Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > devices which use 9p-local driver. > > Signed-off-by: Pradeep Jagadeesh > --- > fsdev/file-op-9p.h | 3 + > fsdev/qemu-fsdev-opts

[Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Pradeep Jagadeesh
Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which use 9p-local driver. Signed-off-by: Pradeep Jagadeesh --- fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 52 + hw/9pfs/9p-local.c | 18 - hw/9pfs/9p-throttle.c | 201 ++